Web server simplifications and handers#7429
Merged
me-no-dev merged 29 commits intoJan 16, 2024
Merged
Conversation
…from MD5 and add some examples. This allows for the cleanup of various to/from HEX routines elsewhere.
VojtechBartoska
added
the
Status: Needs investigation
|
|
Collaborator
|
With the changes a simple Webserver now includes mbedtls software libs. This increases code size a lot. Actually the md5 routine from mbedtls is used which is in all MCUs a routine which is embedded in ROM and does not increase code size. |
Contributor
Author
|
@Jason2866 -- Ok - so your estimate is that by replacing md5 by the rom routines - we can totally remove the need for mbedtls ? Correct ? If so - happy to give that a try. |
Collaborator
|
Yes, see this change #8667 |
lucasssvaz
requested changes
Dec 20, 2023
Member
lucasssvaz
left a comment
lucasssvaz
left a comment
There was a problem hiding this comment.
I think this is a very nice improvement but needs some small fixes first, mainly the mbedtls overhead and the crashing when using a bearer. Please also fix the conflicts to update do 3.0.0
lucasssvaz
added
Resolution: Awaiting response
and removed
Status: Needs investigation
lucasssvaz
force-pushed
the
WebServerSimplificationsAndHanders
branch
from
441848f to
dcd64e1
Compare
lucasssvaz
force-pushed
the
WebServerSimplificationsAndHanders
branch
from
21889f9 to
d24668e
Compare
lucasssvaz
force-pushed
the
WebServerSimplificationsAndHanders
branch
from
98b3d32 to
81663f5
Compare
lucasssvaz
reviewed
Jan 16, 2024
Member
lucasssvaz
left a comment
lucasssvaz
left a comment
There was a problem hiding this comment.
@SuGlider @P-R-O-C-H-Y PR fixed and ready for review
lucasssvaz
approved these changes
Jan 16, 2024
me-no-dev
reviewed
Jan 16, 2024
me-no-dev
reviewed
Jan 16, 2024
lucasssvaz
added
Status: Review needed
me-no-dev
approved these changes
Jan 16, 2024
lucasssvaz
added
Status: Pending Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal to simplify the authentication code in de webserver (and potentially also derisk it); and to also allow for richer authentication; such as with multiple usernames and passwords, the use of Time based one-time passwords or typical IoT bearer tokens.
Also adds a number of extra examples - including one that uses an authentication cookie.
Has been tested on ESP-8266 and ESP-32.